You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Allow setting a map title when creating configuration files - #297
Add an optional Map Title field when creating configuration files. Normalize control characters to spaces, then apply the existing editor title sanitization before saving either a blank map or a copy.
An empty override retains a copied map's title and settings. A supplied title changes only the new copy. A blank source does not attempt to read the config directory. The title handling follows the editor's existing entity-encoding behavior rather than storing raw markup.
Validation: 226 PHP 8.3 tests passed in an isolated fixture layout. Real-engine save/reload tests cover punctuation, markup characters, line-break normalization, blank/copy paths, preserved source settings and an unchanged source file. Syntax, whitespace and manifest checks passed. The coverage gate reports no measured changed production lines because the management entry point has an existing exemption. Full running-installation integration remains unverified for this revision.
Latest review follow-up
Escaped the new translated map-title label and placeholder using __esc(). Added an actual form-fragment rendering regression with translated apostrophes and markup. Latest local validation: 227 PHP tests (5419 assertions). The management entry point is excluded from changed-line coverage; this regression executes the relevant form fragment directly.
These follow-up checks use isolated local fixtures, not a running Cacti installation. PHP 8.3 syntax, whitespace, manifest and translation-template checks passed. GitHub CI must still confirm the revised commits.
Follow-up 3c9c492 normalizes the optional title before checking whether to override an existing/default map title. Real-engine tests cover control-only and mixed-control input; the updated 227-test PHP suite passed locally (5419 assertions).
Merged latest develop and resolved the changelog/translation metadata conflicts in 305ef72, preserving the feature changes. All 232 local PHP tests pass (5466 assertions); syntax, manifest, whitespace and translation-template checks pass. These remain isolated fixture checks, not a fresh full-installation browser audit.
Resolved the new changelog conflict after #292 merged. All 235 local tests pass (5491 assertions), with syntax, manifest and whitespace checks passing. The feature changes remain intact; validation uses isolated fixtures.
Resolved the CHANGELOG.md conflict after #293 merged, preserving both entries. The feature code merged cleanly; all 236 local tests pass, plus manifest and whitespace checks. Validation uses isolated fixtures.
Updated again after #294 merged during the previous push. Resolved the changelog/translation metadata conflicts; code merged cleanly. All 262 local tests pass on this combined revision. Manifest and whitespace checks pass; validation uses isolated fixtures.
Resolved the new CHANGELOG.md conflict after #295 merged. The title and blank-map preset code merged cleanly. All 268 local tests pass (5615 assertions), including real-engine title/preset regressions. PHP syntax, manifest and whitespace checks pass; validation uses isolated fixtures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an optional Map Title field when creating configuration files. Normalize control characters to spaces, then apply the existing editor title sanitization before saving either a blank map or a copy.
An empty override retains a copied map's title and settings. A supplied title changes only the new copy. A blank source does not attempt to read the config directory. The title handling follows the editor's existing entity-encoding behavior rather than storing raw markup.
Validation: 226 PHP 8.3 tests passed in an isolated fixture layout. Real-engine save/reload tests cover punctuation, markup characters, line-break normalization, blank/copy paths, preserved source settings and an unchanged source file. Syntax, whitespace and manifest checks passed. The coverage gate reports no measured changed production lines because the management entry point has an existing exemption. Full running-installation integration remains unverified for this revision.
Latest review follow-up
Escaped the new translated map-title label and placeholder using __esc(). Added an actual form-fragment rendering regression with translated apostrophes and markup. Latest local validation: 227 PHP tests (5419 assertions). The management entry point is excluded from changed-line coverage; this regression executes the relevant form fragment directly.
These follow-up checks use isolated local fixtures, not a running Cacti installation. PHP 8.3 syntax, whitespace, manifest and translation-template checks passed. GitHub CI must still confirm the revised commits.
Follow-up 3c9c492 normalizes the optional title before checking whether to override an existing/default map title. Real-engine tests cover control-only and mixed-control input; the updated 227-test PHP suite passed locally (5419 assertions).